-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter ocp required tests #1696
Filter ocp required tests #1696
Conversation
f001645
to
254aab1
Compare
Example of kind test passing, as the ocp-required tag is there in a dummy test: Example of kind test failing due to missing tag |
6217389
to
f20cee9
Compare
/test test-e2e |
1 similar comment
/test test-e2e |
This adds a new regex in the Ginkgo tests, to ensure we can filter out tests which require OCP from being run during the kind tests. ACM-15734 Signed-off-by: Jacob Baungard Hansen <[email protected]>
f20cee9
to
2d9b17e
Compare
Quality Gate passedIssues Measures |
@jacobbaungard: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobbaungard, subbarao-meduri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds a new regex in the Ginkgo tests, to ensure we can filter out tests which require OCP from being run during the kind tests.
ACM-15734